zhipeng93 commented on code in PR #212:
URL: https://github.com/apache/flink-ml/pull/212#discussion_r1118206725
##########
flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/datagenerator/common/DenseVectorArrayGenerator.java:
##########
@@ -42,7 +42,7 @@ protected RowGenerator[] getRowGenerators() {
return new RowGenerator[] {
new RowGenerator(getNumValues(), getSeed()) {
@Override
- protected Row nextRow() {
+ protected Row getRow() {
Review Comment:
Thanks for the update. Setting the number of pre-generated data as 1/1000
does reduce the variance of the benchmark result here. LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
