lindong28 commented on code in PR #212:
URL: https://github.com/apache/flink-ml/pull/212#discussion_r1118201388
##########
flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/datagenerator/common/DenseVectorArrayGenerator.java:
##########
@@ -42,7 +42,7 @@ protected RowGenerator[] getRowGenerators() {
return new RowGenerator[] {
new RowGenerator(getNumValues(), getSeed()) {
@Override
- protected Row nextRow() {
+ protected Row getRow() {
Review Comment:
I have updated the PR such that it will pre-generate 1/1000 of the expected
number of rows and re-use those rows as the source function output. This allows
the number of unique values to increase with the total number of expected
values. Can you see if this address the concern?
##########
flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/datagenerator/common/DenseVectorArrayGenerator.java:
##########
@@ -42,7 +42,7 @@ protected RowGenerator[] getRowGenerators() {
return new RowGenerator[] {
new RowGenerator(getNumValues(), getSeed()) {
@Override
- protected Row nextRow() {
+ protected Row getRow() {
Review Comment:
I have updated the PR such that it will pre-generate 1/1000 of the expected
number of rows and re-use those rows as the source function output. This allows
the number of unique values to increase with the total number of expected
values. Can you see if this addresses the concern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
