lindong28 commented on code in PR #212:
URL: https://github.com/apache/flink-ml/pull/212#discussion_r1115332664
##########
flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/datagenerator/common/DenseVectorArrayGenerator.java:
##########
@@ -42,7 +42,7 @@ protected RowGenerator[] getRowGenerators() {
return new RowGenerator[] {
new RowGenerator(getNumValues(), getSeed()) {
@Override
- protected Row nextRow() {
+ protected Row getRow() {
Review Comment:
Yes, I think we need to make this optimization since 2 sec still a big
overhead. And previously I have seen bigger difference (more than 3 sec) after
we make this optimization.
We expect Flink ML's performance to be close to Spark ML. That means we
expect Flink ML's total time for this benchmark to be less than 6 sec after we
finish all optimizations. Then 2 sec is going to take a big percentage of the
total time.
Can you explain why this PR will introduce stability issues? Did you observe
additional stability issues after introducing this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
