lindong28 commented on code in PR #212:
URL: https://github.com/apache/flink-ml/pull/212#discussion_r1113027113
##########
flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/datagenerator/common/DenseVectorArrayGenerator.java:
##########
@@ -42,7 +42,7 @@ protected RowGenerator[] getRowGenerators() {
return new RowGenerator[] {
new RowGenerator(getNumValues(), getSeed()) {
@Override
- protected Row nextRow() {
+ protected Row getRow() {
Review Comment:
Good point. I have updated the PR as suggested. The RowGenerator would
generate up to 64 rows and re-use those rows as the source function output.
I have updated the PR description with benchmark results for 3 different
setups. It shows the percentage improvement provided by each optimization. The
overall execution time is smaller than what I observed last time and the
percentage difference is smaller.
Can you take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
