lindong28 commented on PR #21690: URL: https://github.com/apache/flink/pull/21690#issuecomment-1387176214
@1996fanrui @pnowojski Regarding whether `boolean DataOutput#emitRecord`, maybe I can use the example provided by Rui above to elaborate my concern. Let's say we have `MultiInputStreamTask-D` and `OneInputStreamTask-B`. And `MultiInputStreamTask-D` constructed a `DataOutput-C` which is somehow used by `OneInputStreamTask-B`. Now we know that `DataOutput-C::emitRecord` should always return false since it is constructed for `MultiInputStreamTask-D`. This means when `OneInputStreamTask-B` calls `DataOutput-C::emitRecord`, it will always get `false`, which effectively disables the optimization we are trying to make. This is because `DataOutput-C::emitRecord` fails to enforce its semantics when it is used by `OneInputStreamTask-B`. Do you think this example makes sense? Can you help me understand which part of this explanation is incorrect? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
