lindong28 commented on PR #21690: URL: https://github.com/apache/flink/pull/21690#issuecomment-1386947530
``` Returns true if caller can call this method more times within a single invocation of the `PushingAsyncDataInput#emitNext` method. Otherwise returned value false means the caller should return from the `PushingAsyncDataInput#emitNext` invocation as soon as possible. ``` @pnowojski It seems that the API with this semantics is not self-contained. There is no clean way for the implementation of DataOutput#emitRecord() itself to enforce this semantic. And it kinds of couple the constructor of DataOutput with its user to be consistent. For example, a DataOutput created for `MultipleInputStreamTask` will always return false for this method, and thus can not be used by e.g. `OneInputStreamTask`. Ideally, we should allow the interface API to be self-contained so that it de-couples the implementation code from the caller code. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
