lindong28 commented on PR #21690: URL: https://github.com/apache/flink/pull/21690#issuecomment-1386777544
Hmm... if we add the method `boolean DataOutput#emitRecord(...)`, can you explain what Java Doc we should use to explain the semantics of the returned boolean value? Intuitively, the semantics should describe an attribute/state of the DataOutput instance itself and should not change with the caller of this `DataOutput#emitRecord()`. This is the pattern followed by the existing `InputStatus` and `DataInputStatus` enum. However, it seems that in this case the returned boolean will change depending on whether it is called by `OneInputStreamTask` or `MultipleInputStreamTask`, which seems a bit counter intuitive. I am not sure if we can find a reasonable and intuitive semantics for this API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
