pnowojski commented on code in PR #21690:
URL: https://github.com/apache/flink/pull/21690#discussion_r1073379125
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java:
##########
@@ -993,7 +997,7 @@ public MailboxExecutorFactory getMailboxExecutorFactory() {
}
public boolean canEmitBatchOfRecords() {
- return !this.mailboxProcessor.hasMail();
+ return !this.mailboxProcessor.hasMail() && taskIsAvailable();
}
Review Comment:
Could we have a unit test, that would check if this method returns a correct
value? Ideally it would be great to have the assertion not only on the
`StreamTask#canEmitBatchOfRecords()` level, but on the `DataOutput#...` level -
to check that the value is correctly forwarded to the `SourceOperator` and
network input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
