zentol commented on code in PR #21200:
URL: https://github.com/apache/flink/pull/21200#discussion_r1011632646


##########
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterConfiguration.java:
##########
@@ -50,6 +51,8 @@ public class MiniClusterConfiguration {
 
     private final MiniCluster.HaServices haServices;
 
+    @Nullable private final PluginManager pluginManager;

Review Comment:
   > So maybe we should consider documenting it properly and making it a public 
API eventually.
   
   _Eventually_, maybe, but we'd have to make a fair number of changes; it's 
currently exposing to way many internals to be a true user-facing thing.
   
   We'd need a wrapper around it, similar to what the `MiniClusterExtension` 
does. Also, at that point passing a `PluginManager` would again be a no-go 
because that's also an internal API (and I don't think we should change that).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to