rmetzger commented on code in PR #21200:
URL: https://github.com/apache/flink/pull/21200#discussion_r1011419988
##########
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterConfiguration.java:
##########
@@ -50,6 +51,8 @@ public class MiniClusterConfiguration {
private final MiniCluster.HaServices haServices;
+ @Nullable private final PluginManager pluginManager;
Review Comment:
MiniCluster is indeed not documented, hence I agree that it is rather
internal. But I know from at least one other company that has been using it
directly in their production code. So maybe we should consider documenting it
properly and making it a public API eventually.
But I agree with your conclusion that passing an internal API
(`PluginManager`) to another internal API (`MiniCluster`) is fine.
I've pushed a commit addressing your feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
