zentol commented on code in PR #21200:
URL: https://github.com/apache/flink/pull/21200#discussion_r1011288899
##########
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterConfiguration.java:
##########
@@ -100,6 +105,10 @@ public RpcServiceSharing getRpcServiceSharing() {
return rpcServiceSharing;
}
+ public PluginManager getPluginManager() {
Review Comment:
missing `@Nullable`
##########
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterConfiguration.java:
##########
@@ -50,6 +51,8 @@ public class MiniClusterConfiguration {
private final MiniCluster.HaServices haServices;
+ @Nullable private final PluginManager pluginManager;
Review Comment:
I'd have the user pass a `Path` to a plugin directory instead. This exposes
less internals, ensures we can do proper lifecycle management of the plugin
manager and makes it more obvious what you actually have to do to set up
plugins.
Additionally this would allow us to also expose this in the
MiniClusterExtension.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
