zentol commented on code in PR #21200:
URL: https://github.com/apache/flink/pull/21200#discussion_r1011398783
##########
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterConfiguration.java:
##########
@@ -50,6 +51,8 @@ public class MiniClusterConfiguration {
private final MiniCluster.HaServices haServices;
+ @Nullable private final PluginManager pluginManager;
Review Comment:
I mean, you probably shouldn't be using the `MiniCluster` directly in the
first place.
As far as I'm concerned the `MiniCluster` is internal; the
`MiniClusterExtension` is the user-facing API.
That being said, if one considers the `MiniCluster` as internal then
accepting a `PluginManager` is fine; you'll just have to pay the price for
using such APIs.
(At some point) the `MiniClusterExtension` could accept a `Path` and then
construct (and manage) the `PluginManager`.
I do recall users requesting this for testing actually (It's just a bit eh
that we'd support reporter plugins, but not filesystems (damn singletons
:anger: )).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
