[ 
https://issues.apache.org/jira/browse/FLINK-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389776#comment-15389776
 ] 

ASF GitHub Bot commented on FLINK-4192:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/2226
  
    Had a quick offline discussion with @zentol and @aljoscha with the outcome:
    
      - Make `flink-metrics-core` strictly the metrics API project for Metrics 
and Reporters
      - Move all implementations of the metric groups and the MetricRegistry to 
`flink-runtime`.
      - `flink-core` is actually metric free and depends on the metric API 
project only.
    
    Users that want to implement reporters only refer to `flink-metrics-core`. 
For tests, a dependency to `flink-runtime` is needed.
    
    We may move further classes to `flink-metric-core` in the future to reduce 
test dependencies on `flink-runtime`, but that is an open issue at this point.


> Move Metrics API to separate module
> -----------------------------------
>
>                 Key: FLINK-4192
>                 URL: https://issues.apache.org/jira/browse/FLINK-4192
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>    Affects Versions: 1.1.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.1.0
>
>
> All metrics code currently resides in flink-core. If a user implements a 
> reporter and wants a fat jar it will now have to include the entire 
> flink-core module.
> Instead, we could move several interfaces into a separate module.
> These interfaces to move include:
> * Counter, Gauge, Histogram(Statistics)
> * MetricGroup
> * MetricReporter, Scheduled, AbstractReporter
> In addition a new MetricRegistry interface will be required as well as a 
> replacement for the Configuration.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to