curcur commented on a change in pull request #14943:
URL: https://github.com/apache/flink/pull/14943#discussion_r588006640
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/StateBackendLoader.java
##########
@@ -173,6 +186,22 @@ public static StateBackend loadStateBackendFromConfig(
}
}
+ public static StateBackend loadWrappedStateBackendFromConfig(
+ ReadableConfig config, ClassLoader classLoader, @Nullable Logger
logger)
+ throws IllegalConfigurationException, DynamicCodeLoadingException,
IOException {
+
+ checkNotNull(config, "config");
+ checkNotNull(classLoader, "classLoader");
+
+ final StateBackend backend = loadStateBackendFromConfig(config,
classLoader, logger);
+
+ if (config.get(CheckpointingOptions.ENABLE_STATE_CHANGE_LOG)) {
+ return loadChangelogStateBackend(backend, classLoader);
Review comment:
Do you mean `loadStateBackendFromConfig` would return a
StateChangeLogStateBackend?
For now, all the wrapping logic is to construct a
`StateChangeLogStateBackend` is through
`loadChangelogStateBackend`
If we want to load through factory class (which we do not for now), we can
add load through the factory
through `loadChangelogStateBackend` as well.
I think that is logically simpler and cleaner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
