curcur commented on a change in pull request #14943: URL: https://github.com/apache/flink/pull/14943#discussion_r588255677
########## File path: flink-state-backends/flink-statebackend-changelog/src/test/java/org/apache/flink/state/changelog/ChangelogStateBackendLoadingTest.java ########## @@ -0,0 +1,274 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.state.changelog; + +import org.apache.flink.api.common.JobID; +import org.apache.flink.api.common.typeutils.TypeSerializer; +import org.apache.flink.configuration.CheckpointingOptions; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.configuration.IllegalConfigurationException; +import org.apache.flink.configuration.ReadableConfig; +import org.apache.flink.contrib.streaming.state.EmbeddedRocksDBStateBackend; +import org.apache.flink.core.fs.CloseableRegistry; +import org.apache.flink.metrics.MetricGroup; +import org.apache.flink.runtime.execution.Environment; +import org.apache.flink.runtime.query.TaskKvStateRegistry; +import org.apache.flink.runtime.state.AbstractKeyedStateBackend; +import org.apache.flink.runtime.state.AbstractStateBackend; +import org.apache.flink.runtime.state.CheckpointStorage; +import org.apache.flink.runtime.state.CheckpointStorageAccess; +import org.apache.flink.runtime.state.CheckpointStorageLoader; +import org.apache.flink.runtime.state.CompletedCheckpointStorageLocation; +import org.apache.flink.runtime.state.ConfigurableStateBackend; +import org.apache.flink.runtime.state.KeyGroupRange; +import org.apache.flink.runtime.state.KeyedStateHandle; +import org.apache.flink.runtime.state.OperatorStateBackend; +import org.apache.flink.runtime.state.OperatorStateHandle; +import org.apache.flink.runtime.state.StateBackend; +import org.apache.flink.runtime.state.StateBackendLoader; +import org.apache.flink.runtime.state.delegate.DelegatingStateBackend; +import org.apache.flink.runtime.state.hashmap.HashMapStateBackend; +import org.apache.flink.runtime.state.memory.MemoryStateBackend; +import org.apache.flink.runtime.state.storage.JobManagerCheckpointStorage; +import org.apache.flink.runtime.state.ttl.TtlTimeProvider; + +import org.junit.Rule; +import org.junit.Test; +import org.junit.rules.TemporaryFolder; +import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; + +import javax.annotation.Nonnull; + +import java.util.Arrays; +import java.util.Collection; +import java.util.List; + +import static org.junit.Assert.assertSame; +import static org.junit.Assert.assertTrue; + +/** Verify Changelog StateBackend is properly loaded. */ +@RunWith(Parameterized.class) +public class ChangelogStateBackendLoadingTest { + @Rule public final TemporaryFolder tmp = new TemporaryFolder(); + + @Parameterized.Parameters + public static List<Boolean> loadFromConfigOnly() { + return Arrays.asList(true, false); + } + + @Parameterized.Parameter public boolean configOnly; + + private final ClassLoader cl = getClass().getClassLoader(); + + private final String backendKey = CheckpointingOptions.STATE_BACKEND.key(); + + @Test + public void testLoadingDefault() throws Exception { + final StateBackend backend = + StateBackendLoader.loadStateBackendFromApplicationOrConfigOrDefault( + null, config(), cl, null); + final CheckpointStorage storage = + CheckpointStorageLoader.load(null, null, backend, config(), cl, null); + + assertDelegateStateBackend( + backend, HashMapStateBackend.class, storage, JobManagerCheckpointStorage.class); + } + + @Test + public void testLoadingMemoryStateBackendFromConfig() throws Exception { + final Configuration config = config("jobmanager"); + final StateBackend backend = loadStateBackend(config); + final CheckpointStorage storage = + CheckpointStorageLoader.load(null, null, backend, config, cl, null); + + assertDelegateStateBackend( + backend, MemoryStateBackend.class, storage, MemoryStateBackend.class); + } + + @Test + public void testLoadingFsStateBackendFromConfig() throws Exception { + final Configuration config = config("filesystem"); + final StateBackend backend = loadStateBackend(config); + final CheckpointStorage storage = + CheckpointStorageLoader.load(null, null, backend, config, cl, null); + + assertDelegateStateBackend( + backend, HashMapStateBackend.class, storage, JobManagerCheckpointStorage.class); + } + + @Test + public void testLoadingHashMapStateBackendFromConfig() throws Exception { + final Configuration config = config("hashmap"); + final StateBackend backend = loadStateBackend(config); + final CheckpointStorage storage = + CheckpointStorageLoader.load(null, null, backend, config(), cl, null); + + assertDelegateStateBackend( + backend, HashMapStateBackend.class, storage, JobManagerCheckpointStorage.class); + } + + @Test + public void testLoadingRocksDBStateBackendFromConfig() throws Exception { + final Configuration config = config("rocksdb"); + final StateBackend backend = loadStateBackend(config); + final CheckpointStorage storage = + CheckpointStorageLoader.load(null, null, backend, config(), cl, null); + + assertDelegateStateBackend( + backend, + EmbeddedRocksDBStateBackend.class, + storage, + JobManagerCheckpointStorage.class); + } Review comment: The main reason I've added all types of backend loading tests is because of the separation of checkpoint storage and statebackend (and all the default settings), which made the loading a bit complicated. I want to make sure all types/combinations are correct. If later we deprecated and simplify rocksdb/fs/mem statebackend, I think these tests can be removed. But I will try to deduplicate the code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
