curcur commented on a change in pull request #14943: URL: https://github.com/apache/flink/pull/14943#discussion_r585652277
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/delegate/DelegateStateBackend.java ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.state.delegate; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.runtime.state.StateBackend; + +/** + * An interface for delegate state backend. + * + * <p>As its name, it should include a state backend to delegate. The delegated state backend itself + * can not be a {@link DelegateStateBackend}. + * + * <p>TODO: provide configurable way to verify whether a state backend can be delegated. + */ +@Internal +public interface DelegateStateBackend extends StateBackend { Review comment: They are different. First, XXX Reducing/Aggregating State, reducing is quite obviously an adj-noun; while DelegatingStateBackend, I can not tell it is an adj-noun or action; Second, I feel "Reducing" and "Aggregating" themselves are confusing as well; For Map state, should we call it Mapping State? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
