XComp commented on a change in pull request #14465:
URL: https://github.com/apache/flink/pull/14465#discussion_r549672139
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/SlotSharingExecutionSlotAllocatorTest.java
##########
@@ -413,7 +411,10 @@ private static ResourceProfile
fulfilOneOfTwoSlotRequestsAndGetPendingProfile(
return
requests.get(slotRequestId2).getSlotProfile().getPhysicalSlotResourceProfile();
}
- private enum PhysicalSlotFutureCompletionMode {
+ /**
+ * Enum for covering different ways of a Future to complete.
+ */
+ public enum PhysicalSlotFutureCompletionMode {
SUCCESS,
FAILURE,
MANUAL,
Review comment:
I removed it entirely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
