XComp commented on a change in pull request #14465:
URL: https://github.com/apache/flink/pull/14465#discussion_r549702320
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/TestingPhysicalSlotProvider.java
##########
@@ -76,8 +91,10 @@ void completePhysicalSlotFutureFor(
AllocationID allocationID) {
ResourceProfile resourceProfile =
requests.get(slotRequestId).getSlotProfile().getPhysicalSlotResourceProfile();
SharedSlotTestingUtils.TestingPhysicalSlot physicalSlot = new
SharedSlotTestingUtils.TestingPhysicalSlot(
- resourceProfile,
- allocationID);
+ allocationID,
+ taskManagerLocation,
+ taskManagerGateway,
+ resourceProfile);
Review comment:
I don't see the necessity to add another Factory class after the
refactoring. Do you agree? Or would you still prefer having a Factory class
hiding away the `TaskManagerLocation` and `TaskManagerGateway`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
