XComp commented on a change in pull request #14465:
URL: https://github.com/apache/flink/pull/14465#discussion_r549693989
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/TestingPhysicalSlotProvider.java
##########
@@ -56,8 +57,11 @@
private final CountDownLatch allocateLatch;
private volatile int availableSlotCount;
- private
TestingPhysicalSlotProvider(SlotSharingExecutionSlotAllocatorTest.PhysicalSlotFutureCompletionMode
physicalSlotFutureCompletion, TaskManagerLocation taskManagerLocation,
TaskManagerGateway taskManagerGateway, int availableSlotCount) {
+ private final QuinConsumer<CompletableFuture<TestingPhysicalSlot>,
AllocationID, TaskManagerLocation, TaskManagerGateway, ResourceProfile>
physicalSlotCreator;
Review comment:
I refactored it to use a `TriFunctionWithException` returning a
`CompletableFuture` now. I decided to return `CompletableFuture` instances as
there are also use-cases where the slot creation is handled within the test
itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
