XComp edited a comment on pull request #14465: URL: https://github.com/apache/flink/pull/14465#issuecomment-751693135
> I think the refactoring looks good to me. One thing I was wondering whether we can make the configuration of the `SlotSharingExecutionSlotAllocator` a bit easier or whether the nested builder is good enough for it. I counted 6 different parameter combinations which would need to be covered - `()` (i.e. no parameters for customization) - `(PhysicalSlotProvider, allocationTimeout:Time)` - `(SlotSharingStrategyFactory)` - `(availableSlotCount:int)` - `(PhysicalSlotProvider)` - `(allocationTimeout:Time)` Hence, I considered the builder being easier to read. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
