xiaoHoly commented on a change in pull request #14387:
URL: https://github.com/apache/flink/pull/14387#discussion_r547932513
##########
File path:
flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcTableSourceSinkFactoryTest.java
##########
@@ -269,6 +269,17 @@ public void testJdbcValidation() {
fail("exception expected");
} catch (ValidationException ignored) {
}
+
+ // connection.max-retry-timeout property is smaller than 1
second
+ try {
+ Map<String, String> properties = getBasicProperties();
+
properties.put("connector.connection.max-retry-timeout", "100ms");
+
+
TableFactoryService.find(StreamTableSourceFactory.class, properties)
+ .createStreamTableSource(properties);
+ fail("exception expected");
+ } catch (ValidationException ignored) {
+ }
Review comment:
yes，i have noticed what your said. Therefore, i think catch
ValidationException is the current reasonable method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
