zhuzhurk commented on a change in pull request #12917: URL: https://github.com/apache/flink/pull/12917#discussion_r465509662
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolUtils.java ########## @@ -45,19 +50,108 @@ */ public class SlotPoolUtils { + public static final Time TIMEOUT = Time.seconds(10L); + private SlotPoolUtils() { throw new UnsupportedOperationException("Cannot instantiate this class."); } + public static SlotPoolBuilder createSlotPoolBuilder() { Review comment: These `createSlotPoolBuilder(...)` does not show much benefit to me, given that in those tests there are already reusable methods to create and setup slot pool. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org