zhuzhurk commented on a change in pull request #12917:
URL: https://github.com/apache/flink/pull/12917#discussion_r462813177
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolBatchSlotRequestTest.java
##########
@@ -81,8 +67,10 @@ public static void teardownClass() {
*/
@Test
public void testPendingBatchSlotRequestTimeout() throws Exception {
- try (final SlotPoolImpl slotPool = new
SlotPoolBuilder(mainThreadExecutor)
- .build()) {
+ try (final SlotPoolImpl slotPool = slotPoolBuilder
+ .setBatchSlotTimeout(Time.milliseconds(2L))
+ .build()) {
+
final CompletableFuture<PhysicalSlot> slotFuture =
SlotPoolUtils.requestNewAllocatedBatchSlot(
slotPool,
mainThreadExecutor,
Review comment:
I think direct main thread executor cannot work here?
Would you give it a check?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
