zhuzhurk commented on a change in pull request #12917:
URL: https://github.com/apache/flink/pull/12917#discussion_r464357623
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolBatchSlotRequestTest.java
##########
@@ -54,25 +52,17 @@
/**
* Tests for batch slot requests.
*/
-public class SlotPoolBatchSlotRequestTest extends TestLogger {
+public class SlotPoolBatchSlotRequestTest extends SlotPoolTestBase {
private static final ResourceProfile resourceProfile =
ResourceProfile.fromResources(1.0, 1024);
private static final ResourceProfile smallerResourceProfile =
ResourceProfile.fromResources(0.5, 512);
public static final CompletableFuture[] COMPLETABLE_FUTURES_EMPTY_ARRAY
= new CompletableFuture[0];
- private static ScheduledExecutorService
singleThreadScheduledExecutorService;
- private static ComponentMainThreadExecutor mainThreadExecutor;
-
- @BeforeClass
- public static void setupClass() {
- singleThreadScheduledExecutorService =
Executors.newSingleThreadScheduledExecutor();
- mainThreadExecutor =
ComponentMainThreadExecutorServiceAdapter.forSingleThreadExecutor(singleThreadScheduledExecutorService);
- }
- @AfterClass
- public static void teardownClass() {
- if (singleThreadScheduledExecutorService != null) {
- singleThreadScheduledExecutorService.shutdownNow();
- }
+ @Before
+ @Override
+ public void setup() throws Exception {
+ resourceManagerGateway = new TestingResourceManagerGateway();
Review comment:
why not using `resourceManagerGateway` in `SlotPoolTestBase`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
