zhuzhurk commented on a change in pull request #12917:
URL: https://github.com/apache/flink/pull/12917#discussion_r465559499
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolBatchSlotRequestTest.java
##########
@@ -276,4 +289,28 @@ private void
advanceTimeAndTriggerCheckBatchSlotTimeout(TestingSlotPoolImpl slot
// timeout all as unfulfillable marked slots
slotPool.triggerCheckBatchSlotTimeout();
}
+
+ private TestingSlotPoolImpl createAndSetUpSlotPool(
+ final ComponentMainThreadExecutor
componentMainThreadExecutor,
+ final ResourceManagerGateway resourceManagerGateway,
+ final Time batchSlotTimeout) throws Exception {
+
+ return SlotPoolUtils
Review comment:
I see. Makes sense.
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolBatchSlotRequestTest.java
##########
@@ -276,4 +280,28 @@ private void
advanceTimeAndTriggerCheckBatchSlotTimeout(TestingSlotPoolImpl slot
// timeout all as unfulfillable marked slots
slotPool.triggerCheckBatchSlotTimeout();
}
+
+ private TestingSlotPoolImpl createAndSetUpSlotPool(
+ final ComponentMainThreadExecutor
componentMainThreadExecutor,
+ final ResourceManagerGateway resourceManagerGateway,
Review comment:
```suggestion
@Nullable final ResourceManagerGateway
resourceManagerGateway,
```
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolBatchSlotRequestTest.java
##########
@@ -276,4 +280,28 @@ private void
advanceTimeAndTriggerCheckBatchSlotTimeout(TestingSlotPoolImpl slot
// timeout all as unfulfillable marked slots
slotPool.triggerCheckBatchSlotTimeout();
}
+
+ private TestingSlotPoolImpl createAndSetUpSlotPool(
+ final ComponentMainThreadExecutor
componentMainThreadExecutor,
+ final ResourceManagerGateway resourceManagerGateway,
+ final Time batchSlotTimeout) throws Exception {
+
+ return new SlotPoolBuilder(componentMainThreadExecutor)
+ .setResourceManagerGateway(resourceManagerGateway)
+ .setBatchSlotTimeout(batchSlotTimeout)
+ .build();
+ }
+
+ private TestingSlotPoolImpl createAndSetUpSlotPool(
+ final ComponentMainThreadExecutor
componentMainThreadExecutor,
+ final ResourceManagerGateway resourceManagerGateway,
Review comment:
```suggestion
@Nullable final ResourceManagerGateway
resourceManagerGateway,
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
