aljoscha commented on pull request #12132: URL: https://github.com/apache/flink/pull/12132#issuecomment-629772729
Thanks for the update! @guoweiM I quite like your changes to the test because you simplified it quite a bit. However, the important point is that the test is added separately before the rework, and that the snapshot files are not changed afterwards, to ensure that restoring them really works. I updated my branch to do just that: https://github.com/aljoscha/flink/commits/pr-12132-file-sink. I also merged @kl0u's suggestions into your commit. You can see that your commit barely needs to change the serializer test and that restoring from v1 still works. I then upgraded the test with snapshots for v2, however, those tests are currently failing. Could you try and figure out why they are failing? You can take my branch, force push it to your branch and then continue working on that. @JingsongLi I think I also rebased that on master. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
