guoweiM commented on pull request #12132:
URL: https://github.com/apache/flink/pull/12132#issuecomment-629604823
Hi, @kl0u thanks for your review.
1. You are right. We could rename the `PartFileWriter` to
`InProgressFileWriter`.
2. You are very careful. We should remove the `getRecoverable` from
`PendingFile`. :-)
3. Maybe I am missing something but I am a little wonder about the rename
the `PartFileFacory` to the `BulkWriter`:
1. The methods in the `BulkWriter` are all about how to handle the part
file. Such as create/resume InProgressWriter which is responsible for writing
data to the in-progress part file and recover the pending part file.
1. The subtype of `BulkWriter` is also about handling the part file
differently such as format or commit and so on.
4. So I think the old `PartFileFactory` is more suitable and we could call
the `WriterProperties` to `PartFileFactoryProperites`. What do you think?
Correct me if I misunderstand some thing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
