kl0u commented on pull request #12132: URL: https://github.com/apache/flink/pull/12132#issuecomment-629626868
Hi @guoweiM , I am proposing to name the factory `BucketWriter`, not `BulkWriter` :) (I also get confused). The reason for this is because it does not only create `InProgressWriter`s but also resumes/handles `PendingFiles`. So it is not only an `InProgressWriterFactory` anymore, but it is responsible for all the "types" of files we use when writing to a `Bucket` (pending and in-progress). Also, in the properties, it contains general information about how we write to a `Bucket` like serializers and if we allow resuming or not. WDYT? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
