guoweiM edited a comment on pull request #12132: URL: https://github.com/apache/flink/pull/12132#issuecomment-629650094
Hi, @aljoscha thanks for your review and suggestion. 1. yes you are right I should delete the v1 code in the test. 1. The reason I used Operator to generate snapshots at the time is that we could use a set of code to generate both v1 and v2 snapshots of `BucketState`. 1. Otherwise, I would have to write twice for how to generate `BucketStatev1` and `BucketStateV2`. 1. There is a special process also needs to be written twice. The path in the snapshot cannot have an absolute path and needs to be specially processed when the snapshot is generated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org