godfreyhe commented on a change in pull request #11340: [Flink 14338] Upgrade Calcite version to 1.22 for Flink SQL URL: https://github.com/apache/flink/pull/11340#discussion_r391373689
########## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/metadata/FlinkRelMetadataQuery.java ########## @@ -34,8 +34,6 @@ */ public class FlinkRelMetadataQuery extends RelMetadataQuery { - protected static final FlinkRelMetadataQuery PROTOTYPE = new FlinkRelMetadataQuery(false); Review comment: I think we should keep this, because this could avoid creating metadata handler instance again and again, this is similar to `RelMetadataQuery`, it's good for performance. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services