godfreyhe commented on a change in pull request #11340: [Flink 14338] Upgrade Calcite version to 1.22 for Flink SQL URL: https://github.com/apache/flink/pull/11340#discussion_r391497619
########## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/plan/batch/sql/join/ShuffledHashSemiAntiJoinTest.scala ########## @@ -164,22 +164,16 @@ class ShuffledHashSemiAntiJoinTest extends SemiAntiJoinTestBase { @Test override def testExistsWithCorrelated_LateralTableInSubQuery(): Unit = { - thrown.expect(classOf[TableException]) - thrown.expectMessage("Cannot generate a valid execution plan for the given query") super.testExistsWithCorrelated_LateralTableInSubQuery() } @Test override def testInWithUncorrelated_LateralTableInSubQuery(): Unit = { - thrown.expect(classOf[TableException]) - thrown.expectMessage("Cannot generate a valid execution plan for the given query") super.testInWithUncorrelated_LateralTableInSubQuery() } @Test override def testInWithCorrelated_LateralTableInSubQuery(): Unit = { - thrown.expect(classOf[TableException]) - thrown.expectMessage("Cannot generate a valid execution plan for the given query") super.testInWithCorrelated_LateralTableInSubQuery() Review comment: remove those three methods from this class, because the code is same with the super methods ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services