godfreyhe commented on a change in pull request #11340: [Flink 14338] Upgrade
Calcite version to 1.22 for Flink SQL
URL: https://github.com/apache/flink/pull/11340#discussion_r391452344
##########
File path:
flink-table/flink-table-planner-blink/src/test/resources/org/apache/flink/table/planner/plan/batch/sql/agg/DistinctAggregateTest.xml
##########
@@ -193,14 +193,14 @@ LogicalAggregate(group=[{}], EXPR$0=[COUNT(DISTINCT
$0)], EXPR$1=[SUM(DISTINCT $
</Resource>
<Resource name="planAfter">
<![CDATA[
-SortAggregate(isMerge=[true], select=[Final_COUNT(count$0) AS EXPR$0,
Final_SUM(sum$1) AS EXPR$1, Final_MIN(min$2) AS EXPR$2])
+SortAggregate(isMerge=[true], select=[Final_COUNT(count$0) AS EXPR$0,
Final_SUM(sum$1) FILTER min$2 AS EXPR$1, Final_MIN(min$2) AS EXPR$2])
Review comment:
`FILTER min$2` is unnecessary, because the local aggregate has do the filter
` Partial_SUM(a) FILTER $g_0 AS sum$`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
