godfreyhe commented on a change in pull request #11340: [Flink 14338] Upgrade 
Calcite version to 1.22 for Flink SQL
URL: https://github.com/apache/flink/pull/11340#discussion_r391409405
 
 

 ##########
 File path: 
flink-table/flink-table-planner-blink/src/test/resources/org/apache/flink/table/planner/plan/stream/sql/DeduplicateTest.xml
 ##########
 @@ -36,7 +36,7 @@ LogicalProject(a=[$0], rank_num=[$1])
     </Resource>
     <Resource name="planAfter">
       <![CDATA[
-Calc(select=[a, 2:BIGINT AS rank_num])
+Calc(select=[a, 2:BIGINT AS $1])
 
 Review comment:
   we should keep the original field name, the field index (like `$1`) is 
meaningless

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to