carp84 commented on a change in pull request #10768: [FLINK-15012][checkpoint]
Introduce shutdown to CheckpointStorageCoordinatorView to clean up checkpoint
directory.
URL: https://github.com/apache/flink/pull/10768#discussion_r386015007
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/state/filesystem/AbstractFileCheckpointStorageTestBase.java
##########
@@ -229,6 +231,41 @@ public void writeToAlreadyExistingCheckpointFails()
throws Exception {
catch (IOException ignored) {}
}
+ @Test
+ public void testShutDownStorageOnNeverRetain() throws IOException {
+
verifyStorageShutDownAsExpected(CheckpointRetentionPolicy.NEVER_RETAIN_AFTER_TERMINATION,
JobStatus.CANCELED, false);
+
+
verifyStorageShutDownAsExpected(CheckpointRetentionPolicy.NEVER_RETAIN_AFTER_TERMINATION,
JobStatus.FINISHED, false);
+
+
verifyStorageShutDownAsExpected(CheckpointRetentionPolicy.NEVER_RETAIN_AFTER_TERMINATION,
JobStatus.FAILED, false);
Review comment:
Should also cover `JobStatus.SUSPENDED`. The same for tests on other
policies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
