carp84 commented on a change in pull request #10768: [FLINK-15012][checkpoint]
Introduce shutdown to CheckpointStorageCoordinatorView to clean up checkpoint
directory.
URL: https://github.com/apache/flink/pull/10768#discussion_r386012480
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -277,6 +277,7 @@ public CheckpointCoordinator(
try {
this.checkpointStorage =
checkpointStateBackend.createCheckpointStorage(job);
+
checkpointStorage.setCheckpointProperties(checkpointProperties);
Review comment:
`CheckpointStorage` is used on both JM and TM side, and the
`checkpointProperties` is only required by `CheckpointCoordinator`, so it
should not be a property in `CheckpointStorage`. Instead, we should pass it in
as a parameter in `CheckpointStorageCoordinatorView#shutDown`.
Accordingly, we don't need to introduce the setter interface in
`CheckpointStorageCoordinatorView` any more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
