carp84 commented on a change in pull request #10768: [FLINK-15012][checkpoint]
Introduce shutdown to CheckpointStorageCoordinatorView to clean up checkpoint
directory.
URL: https://github.com/apache/flink/pull/10768#discussion_r386012585
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/CheckpointStorageCoordinatorView.java
##########
@@ -103,4 +106,23 @@
CheckpointStorageLocation initializeLocationForSavepoint(
long checkpointId,
@Nullable String externalLocationPointer) throws IOException;
+
+ /**
+ * Sets the checkpoint properties which used when shutting down the
storage to the checkpoint storage.
+ *
+ * @param checkpointProperties The checkpoint properties to forward.
+ */
+ void setCheckpointProperties(CheckpointProperties checkpointProperties);
+
+ /**
+ * Shuts down the checkpoint storage on the coordinator side with given
job status.
+ *
+ * <p>The job status is forwarded and used to decide whether checkpoint
directory should
+ * actually be discarded or kept.
+ *
+ * @param jobStatus The job status on shut down.
+ *
+ * @throws IOException Thrown if the storage cannot be shut down well
due to an I/O exception.
+ */
+ void shutDown(JobStatus jobStatus) throws IOException;
Review comment:
```suggestion
void shutDown(JobStatus jobStatus, CheckpointProperties
checkpointProperties) throws IOException;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
