carp84 commented on a change in pull request #10768: [FLINK-15012][checkpoint] Introduce shutdown to CheckpointStorageCoordinatorView to clean up checkpoint directory. URL: https://github.com/apache/flink/pull/10768#discussion_r386013559
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointProperties.java ########## @@ -103,7 +103,7 @@ boolean forceCheckpoint() { * * @see CompletedCheckpointStore */ - boolean discardOnSubsumed() { + public boolean discardOnSubsumed() { Review comment: This change is unnecessary. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services