danny0405 commented on a change in pull request #10536:
[FLINK-15191][connectors / kafka]Fix can't create table source for Kafka if
watermark or computed column is defined.
URL: https://github.com/apache/flink/pull/10536#discussion_r357476447
##########
File path:
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/utils/TestTableSourceFactoryBase.java
##########
@@ -126,7 +138,9 @@ public String getProperty() {
@Override
public TypeInformation<Row> getReturnType() {
- return Types.ROW(schema.getFieldNames(),
schema.getFieldTypes());
+ return Types.ROW(
+
TableSchemaUtils.filterGeneratedColumn(schema).getFieldNames(),
+
TableSchemaUtils.filterGeneratedColumn(schema).getFieldTypes());
Review comment:
Reuse the schema generated by
`TableSchemaUtils.filterGeneratedColumn(schema).getFieldNames()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
