danny0405 commented on a change in pull request #10536: [FLINK-15191][connectors / kafka]Fix can't create table source for Kafka if watermark or computed column is defined. URL: https://github.com/apache/flink/pull/10536#discussion_r357487533
########## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/utils/InMemoryTableFactory.scala ########## @@ -19,19 +19,20 @@ package org.apache.flink.table.utils import java.util + import org.apache.flink.api.java.typeutils.RowTypeInfo import org.apache.flink.table.api.TableSchema import org.apache.flink.table.descriptors.ConnectorDescriptorValidator.{CONNECTOR_PROPERTY_VERSION, CONNECTOR_TYPE} import org.apache.flink.table.descriptors.Rowtime._ import org.apache.flink.table.descriptors.Schema._ import org.apache.flink.table.descriptors.{DescriptorProperties, SchemaValidator} +import org.apache.flink.table.descriptors.DescriptorProperties.{TABLE_SCHEMA_EXPR, WATERMARK, WATERMARK_ROWTIME, WATERMARK_STRATEGY_DATA_TYPE, WATERMARK_STRATEGY_EXPR} import org.apache.flink.table.factories.{StreamTableSinkFactory, StreamTableSourceFactory, TableFactory} import org.apache.flink.table.sinks.StreamTableSink import org.apache.flink.table.sources.StreamTableSource import org.apache.flink.table.types.logical.LogicalTypeRoot import org.apache.flink.table.types.utils.TypeConversions.fromDataTypeToLegacyInfo import org.apache.flink.types.Row - import java.sql.Timestamp Review comment: unnecessary change. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services