danny0405 commented on a change in pull request #10536:
[FLINK-15191][connectors / kafka]Fix can't create table source for Kafka if
watermark or computed column is defined.
URL: https://github.com/apache/flink/pull/10536#discussion_r357476122
##########
File path:
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCUpsertTableSink.java
##########
@@ -118,7 +119,9 @@ public void setIsAppendOnly(Boolean isAppendOnly) {
@Override
public TypeInformation<Row> getRecordType() {
- return new RowTypeInfo(schema.getFieldTypes(),
schema.getFieldNames());
+ return new RowTypeInfo(
+
TableSchemaUtils.filterGeneratedColumn(schema).getFieldTypes(),
Review comment:
```java
TableSchema physicalSchema = TableSchemaUtils.filterGeneratedColumn(schema);
return new RowTypeInfo(schema.getFieldTypes(), schema.getFieldNames());
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
