danny0405 commented on a change in pull request #10536:
[FLINK-15191][connectors / kafka]Fix can't create table source for Kafka if
watermark or computed column is defined.
URL: https://github.com/apache/flink/pull/10536#discussion_r357478162
##########
File path:
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/descriptors/SchemaValidator.java
##########
@@ -269,12 +320,14 @@ else if (isRowtime) {
mapping.put(name, source.get());
} else { // implicit mapping or time
boolean isProctime = properties
- .getOptionalBoolean(SCHEMA +
"." + i + "." + SCHEMA_PROCTIME)
- .orElse(false);
+ .getOptionalBoolean(SCHEMA + "." + i +
"." + SCHEMA_PROCTIME)
+ .orElse(false);
boolean isRowtime = properties
- .containsKey(SCHEMA + "." + i +
"." + ROWTIME_TIMESTAMPS_TYPE);
+ .containsKey(SCHEMA + "." + i + "." +
ROWTIME_TIMESTAMPS_TYPE);
+ boolean isGeneratedColumn = properties
+ .containsKey(SCHEMA + "." + i + "." +
TABLE_SCHEMA_EXPR);
// remove proctime/rowtime from mapping
Review comment:
Add a test case in `SchemaValidatorTest`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
