wangyang0918 commented on a change in pull request #10193: [FLINK-13938][yarn]
Use pre-uploaded flink binary to accelerate flink submission
URL: https://github.com/apache/flink/pull/10193#discussion_r347812353
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java
##########
@@ -263,6 +298,36 @@ private static LocalResource
registerLocalResource(FileSystem fs, Path remoteRsr
return localResource;
}
+ /**
+ * Register a local resource with resource info. The resource info may
contains multiple parts.
+ * For example,
RemotePath;[resourceSize;resourceModificationTime;LocalResourceVisibility]
+ * @param resourceInfoStr resource info string
+ * @param yarnConfig yarn configuration
+ * @return local resource tuple, f0 is filename, f1 is local resource.
+ */
+ private static Tuple2<String, LocalResource> registerLocalResource(
Review comment:
I prefer the name `registerLocalResource`. It has different overloadings.
```
private static LocalResource registerLocalResource(Path remoteRsrcPath, long
resourceSize, long resourceModificationTime, LocalResourceVisibility visibility)
private static LocalResource registerLocalResource(FileSystem fs, Path
remoteRsrcPath)
private static Tuple2<String, LocalResource> registerLocalResource(String
resourceDesStr, Configuration yarnConfig)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
