wangyang0918 commented on a change in pull request #10193: [FLINK-13938][yarn]
Use pre-uploaded flink binary to accelerate flink submission
URL: https://github.com/apache/flink/pull/10193#discussion_r347805777
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java
##########
@@ -149,61 +155,79 @@ public static void setupYarnClassPath(Configuration
conf, Map<String, String> ap
String appId,
Path localSrcPath,
Path homedir,
- String relativeTargetPath) throws IOException {
-
- File localFile = new File(localSrcPath.toUri().getPath());
- if (localFile.isDirectory()) {
- throw new IllegalArgumentException("File to copy must
not be a directory: " +
- localSrcPath);
- }
+ String relativeTargetPath,
+ @Nullable FileStatus preUploadedFileStatus) throws IOException {
Review comment:
Thanks @TisonKun and @walterddr. It makes sense to me. I will split in into
two methods `setupLocalResource()` and `setupPreUploadedResource`.
However, i suggest not to change the name `registerLocalResource`. Since the
local not means the local file, it means the Yarn `LocalResource`. It is a
proper noun of Yarn.
```
LocalResource localResource = Records.newRecord(LocalResource.class);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
