wangyang0918 commented on a change in pull request #10193: [FLINK-13938][yarn] Use pre-uploaded flink binary to accelerate flink submission URL: https://github.com/apache/flink/pull/10193#discussion_r350218527
########## File path: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java ########## @@ -129,6 +134,33 @@ public static void setupYarnClassPath(Configuration conf, Map<String, String> ap } } + /** + * Setup and register a pre-uploaded resource according to the file status. + * + * @param localSrcPath + * path to the local file + * relative target path of the file (will be prefixed be the full home directory we set up) + * @param preUploadedFileStatus + * the corresponding pre-uploaded file status of localSrcPath + * + * @return Path to remote file (usually hdfs) + */ + static Tuple2<Path, LocalResource> setupPreUploadedResource( Review comment: The preUploaded Resources means they have been uploaded to hdfs already, not Yarn public cache. I have to make clear that Yarn public cache is a type of `LocalResourceVisibility`. The public cache will be downloaded only once in the same NodeManager and could be shared by different applications. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services