wangyang0918 commented on a change in pull request #10193: [FLINK-13938][yarn]
Use pre-uploaded flink binary to accelerate flink submission
URL: https://github.com/apache/flink/pull/10193#discussion_r350606257
##########
File path: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNITCase.java
##########
@@ -93,8 +114,8 @@ private void
deployPerjob(YarnConfigOptions.UserJarInclusion userJarInclusion) t
true)) {
yarnClusterDescriptor.setLocalJarPath(new
Path(flinkUberjar.getAbsolutePath()));
-
yarnClusterDescriptor.addShipFiles(Arrays.asList(flinkLibFolder.listFiles()));
-
yarnClusterDescriptor.addShipFiles(Arrays.asList(flinkShadedHadoopDir.listFiles()));
+
yarnClusterDescriptor.addShipFiles(Collections.singletonList(flinkLibFolder));
Review comment:
Yes, you are right. Flink will iterate over a directory. So i just make the
test to keep the same behavior with `YarnClusterDescriptor`.
`YarnClusterDescriptor` add the `lib` folder as ship file, not all the files.
We find the corresponding pre-uploaded file by the same relative path with
local file. So it is important to test the real behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
