zhijiangW commented on a change in pull request #8485: [FLINK-12555] Introduce
an encapsulated metric group layout for shuffle API
URL: https://github.com/apache/flink/pull/8485#discussion_r291069560
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
##########
@@ -70,18 +70,35 @@
private static final Logger LOG =
LoggerFactory.getLogger(NetworkEnvironment.class);
+ // deprecated metric groups
+
+ @SuppressWarnings("DeprecatedIsStillUsed")
+ @Deprecated
+ private static final String METRIC_GROUP_NETWORK_DEPRECATED = "Network";
@SuppressWarnings("DeprecatedIsStillUsed")
- @Deprecated private static final String METRIC_GROUP_NETWORK_DEPRECATED
= "Network";
+ @Deprecated
+ private static final String METRIC_GROUP_BUFFERS_DEPRECATED = "buffers";
+
+ // shuffle environment level metrics: Shuffle.Netty.*
+
+ private static final String METRIC_TOTAL_MEMORY_SEGMENT =
"TotalMemorySegments";
+ private static final String METRIC_AVAILABLE_MEMORY_SEGMENT =
"AvailableMemorySegments";
+
+ // task level metric group structure:
Shuffle.Netty.<Input|Output>.Buffers
+
private static final String METRIC_GROUP_SHUFFLE = "Shuffle";
private static final String METRIC_GROUP_NETTY = "Netty";
private static final String METRIC_GROUP_OUTPUT = "Output";
private static final String METRIC_GROUP_INPUT = "Input";
private static final String METRIC_GROUP_BUFFERS = "Buffers";
- private static final String METRIC_TOTAL_MEMORY_SEGMENT =
"TotalMemorySegments";
- private static final String METRIC_AVAILABLE_MEMORY_SEGMENT =
"AvailableMemorySegments";
+
+ // task level output metrics: Shuffle.Netty.Output.*
private static final String METRIC_OUTPUT_QUEUE_LENGTH =
"outputQueueLength";
private static final String METRIC_OUTPUT_POOL_USAGE = "outPoolUsage";
+
+ // task level output metrics: Shuffle.Netty.Input.*
Review comment:
output -> input
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
