zhijiangW commented on a change in pull request #8485: [FLINK-12555] Introduce
an encapsulated metric group layout for shuffle API
URL: https://github.com/apache/flink/pull/8485#discussion_r291009444
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
##########
@@ -228,7 +236,8 @@ public void
releasePartitions(Collection<ResultPartitionID> partitionIds) {
resultPartitions[counter++] =
resultPartitionFactory.create(taskName, executionId, rpdd);
}
- registerOutputMetrics(outputGroup, buffersGroup,
resultPartitions);
+ MetricGroup outputMetricGroup =
taskMetricGroup.addGroup(METRIC_GROUP_OUTPUT);
+ registerOutputMetrics(outputMetricGroup,
outputMetricGroup.addGroup(METRIC_GROUP_BUFFERS), resultPartitions);
Review comment:
Maybe we could only pass `outputMetricGroup` here and make
`outputMetricGroup.addGroup(METRIC_GROUP_BUFFERS)` inside
`registerOutputMetrics`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
