zhijiangW commented on a change in pull request #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API URL: https://github.com/apache/flink/pull/8485#discussion_r291012117
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java ########## @@ -69,7 +70,13 @@ private static final Logger LOG = LoggerFactory.getLogger(NetworkEnvironment.class); - private static final String METRIC_GROUP_NETWORK = "Network"; + @SuppressWarnings("DeprecatedIsStillUsed") + @Deprecated private static final String METRIC_GROUP_NETWORK_DEPRECATED = "Network"; Review comment: Put `@Deprecated` in separate line? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services