zhijiangW commented on a change in pull request #8485: [FLINK-12555] Introduce 
an encapsulated metric group layout for shuffle API
URL: https://github.com/apache/flink/pull/8485#discussion_r291913232
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ShuffleEnvironment.java
 ##########
 @@ -92,25 +92,34 @@
         */
        int start() throws IOException;
 
+       /**
+        * Create a context of the shuffle input/output owner used to create 
partitions or gates belonging to the owner.
+        *
+        * <p>This method has to be called only once to avoid duplicated 
internal metric group registration.
+        *
+        * @param ownerName the owner name, used for logs
+        * @param executionAttemptID execution attempt id of the producer or 
consumer
 
 Review comment:
   of the producer or consumer -> of the owner?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to