yanghua commented on a change in pull request #7571: [FLINK-10724] Refactor
failure handling in check point coordinator
URL: https://github.com/apache/flink/pull/7571#discussion_r276150565
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java
##########
@@ -101,7 +100,7 @@
private final CheckpointStorageLocation targetLocation;
/** The promise to fulfill once the checkpoint has been completed. */
- private final CompletableFuture<CompletedCheckpoint>
onCompletionPromise;
+ private final CompletableFuture<CheckpointExecutionResult>
onCompletionPromise;
Review comment:
@StefanRRichter Let me give more explanation to my second advantage,
`CheckpointTriggerResult` is the existing design in Flink source code
currently. I just try to keep the design of `CheckpointExecutionResult` close
to `CheckpointTriggerResult`. The implementation of
`CheckpointExecutionResult`(`null` and ISE, and provided methods) is similar
with `CheckpointTriggerResult`(about `null` and ISE, actually the two `getXXX`
methods can be used in combination with two `isXXX` methods, it would be not
very serious). In my design document, The `CheckpointFailureManager` just care
about `CheckpointTriggerResult` and `CheckpointExecutionResult`, not the three
methods you mentioned, they are `handleCheckpointTriggerResult` and
`handleCheckpointExecuteResult`. It will make the source code more clear that
the failure processing would be split into two stages: **trigger** and
**execution**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
